refactor(preset-classic): migrate preset-classic to TypeScript#5579
Merged
slorber merged 1 commit intofacebook:mainfrom Sep 22, 2021
Merged
refactor(preset-classic): migrate preset-classic to TypeScript#5579slorber merged 1 commit intofacebook:mainfrom
slorber merged 1 commit intofacebook:mainfrom
Conversation
|
✔️ [V2] 🔨 Explore the source changes: 9b97744 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61443f0a7114bb0007f0b4c7 😎 Browse the preview: https://deploy-preview-5579--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5579--docusaurus-2.netlify.app/ |
slorber
added
the
pr: maintenance
Collaborator
|
Thanks, LGTM 👍 |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In the meantime, I noticed that using
interfaceinstead oftypewould result in a lack ofstringindex signature when assigning toPluginOptions, so made modifications where necessary.Have you read the Contributing Guidelines on pull requests?
Yes