feat(content-blog): allow sorting posts in ascending order#5787
feat(content-blog): allow sorting posts in ascending order#5787slorber merged 4 commits intofacebook:mainfrom
Conversation
cerkiewny
force-pushed
the
feature/custom_blog_order
branch
from
e6baf77 to
f5595d5
Compare
|
✔️ [V2] 🔨 Explore the source changes: e6baf77 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6177269237c261000741f929 😎 Browse the preview: https://deploy-preview-5787--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5787--docusaurus-2.netlify.app/ |
|
✔️ [V2] 🔨 Explore the source changes: f5595d5 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/617727b6c80df900076f3595 😎 Browse the preview: https://deploy-preview-5787--docusaurus-2.netlify.app |
|
✔️ [V2] 🔨 Explore the source changes: f3f14f9 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/618a437801d89a000797e8c7 😎 Browse the preview: https://deploy-preview-5787--docusaurus-2.netlify.app |
|
Sure, sounds good I'll resubmit PR at the end or just after weekend |
No need to close the current one, just change the current one |
|
Josh-Cena
changed the title
cerkiewny
force-pushed
the
feature/custom_blog_order
branch
from
d5104eb to
f28279e
Compare
Josh-Cena
left a comment
Josh-Cena
left a comment
There was a problem hiding this comment.
I think it mostly looks good in terms of implementation. In terms of whether we want this API or not... not sure🤔
Several API design suggestions:
postSortDirection=>sortPosts(we can have other options in the future)'desc'=>'descending'(it's better to be explicit IMO)
cerkiewny
force-pushed
the
feature/custom_blog_order
branch
from
b52ff03 to
dfc615c
Compare
| | `feedOptions.description` | `string` | <code>\`${siteConfig.title} Blog\`</code> | Description of the feed. | | ||
| | `feedOptions.copyright` | `string` | `undefined` | Copyright message. | | ||
| | `feedOptions.language` | `string` (See [documentation](http://www.w3.org/TR/REC-html40/struct/dirlang.html#langcodes) for possible values) | `undefined` | Language metadata of the feed. | | ||
| | `postSorting` | <code>'descending' \| 'ascending' </code> | `'descending'` | Governs the direction of blog post sorting. | |
There was a problem hiding this comment.
| | `postSorting` | <code>'descending' \| 'ascending' </code> | `'descending'` | Governs the direction of blog post sorting. | | |
| | `sortPosts` | <code>'descending' \| 'ascending' </code> | `'descending'` | Governs the direction of blog post sorting. | |
|
LGTM
|
|
Just curious, are you using this feature @cerkiewny? Do you expect the RSS feed to be in ascending order too? 🤔 Asking for #9827 (comment) |
4 participants
Motivation
Fix #5692
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Regression tests for older relevant tests.
Created new test that sorts posts in reverse creation order and compare it to default option.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)