fix: move docusaurus core back to hard dependencies#6078
fix: move docusaurus core back to hard dependencies#6078slorber merged 4 commits intofacebook:mainfrom pranabdas:main
Conversation
While upgrading to latest beta 10, it gives @docusaurus/core peer dependency error due to different versions required by @docusaurus/preset-classic and root @docusaurus/core. Current canary release seems broken as well because of this inconsistent requirements for @docusaurus/preset-classic and root @docusaurus/core.
|
✔️ [V2] 🔨 Explore the source changes: 098369d 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61b3233fb2594000071c9f9c 😎 Browse the preview: https://deploy-preview-6078--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6078--docusaurus-2.netlify.app/ |
| }, | ||
| "peerDependencies": { | ||
| "@docusaurus/core": "2.0.0-beta.9", | ||
| "@docusaurus/core": "2.0.0-beta.10", |
There was a problem hiding this comment.
maybe we should make it an range? ^2.0.0
There was a problem hiding this comment.
I don't think ranges work for beta tags. But I could be wrong
There was a problem hiding this comment.
Caret ranges do work: https://docs.npmjs.com/cli/v6/using-npm/semver#prerelease-tags
I will probably be going for a range, because if lerna doesn't want to update peer dependencies (#6047 (comment)) we'd have to make it future-proof
|
For now I'm reverting the peerDep to a regular dep (how it used to be) |
While upgrading to latest beta 10, it gives
@docusaurus/corepeer dependency error due to different versions required by@docusaurus/preset-classicand root@docusaurus/core. Current canary release seems broken as well because of this inconsistent requirements.Motivation
Trying to fix the peer dependency error while upgrading to the latest beta 10.
Details of error:
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Sorry, I don't know how to test npm releases.