fix: declare missing dependencies#6097
Conversation
|
✔️ [V2] 🔨 Explore the source changes: bd6e9cb 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61b4b8c1582f2c0007b3fdf9 😎 Browse the preview: https://deploy-preview-6097--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6097--docusaurus-2.netlify.app/ |
|
✔️ [V2] 🔨 Explore the source changes: fb24179 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61b55466fe13cb0007f822cf 😎 Browse the preview: https://deploy-preview-6097--docusaurus-2.netlify.app |
|
Thanks, do you think it makes more sense to declare react as optional peer deps in |
|
It's currently always imported so no, if it was changed to use dynamic imports then sure. |
Motivation
#6047 made Docusaurus PnP strict mode compatible but by default PnP still allows some fallbacks, this PR disables that fallback in the e2e test and adds the remaining undeclared dependencies.
Have you read the [Contributing Guidelines on pull requests]
Yes
Test Plan
The e2e test passes