fix(theme-common): docs breadcrumbs not working with baseUrl#6816
Conversation
|
✔️ [V2] 🔨 Explore the source changes: ea1bc09 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/621f992eeb75030007a53149 😎 Browse the preview: https://deploy-preview-6816--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6816--docusaurus-2.netlify.app/ |
|
Size Change: +74 B (0%) Total Size: 789 kB
ℹ️ View Unchanged
|
|
@slorber So the home icon in breadcrumbs is not supposed to show up for docs-only sites? The breadcrumb looks bit empty in this case if there is only one item. Is it possible to have home icon in this case linking to |
|
yes it's showing for docs-only sites if there's a doc with slug: / For breadcrumbs improvements, I suggest giving your opinion here: #6786 I don't know if Maybe it would be better to always ensure/force that a docs site has a home 🤷♂️ At least you could provide a redirect from |
|
Maybe there is a bug then, the home icon is not showing up in the breadcrumb in docs-only mode. Steps to reproduce:
|
|
Indeed, it's because the version route that the doc plugin doesn't specify |
|
hmmm weird, I tested this locally and it worked 😅 Will fix this asap |

Motivation
fix bug reported here: #6749 (comment)
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
unit tests