Skip to content

fix(theme-classic): do not add caret for non-collapsible categories#7015

Merged
Josh-Cena merged 1 commit intomainfrom
jc/fix-sideba
Mar 26, 2022
Merged

fix(theme-classic): do not add caret for non-collapsible categories#7015
Josh-Cena merged 1 commit intomainfrom
jc/fix-sideba

Conversation

@Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented Mar 26, 2022

Motivation

A caret is added for even non-collapsible categories:

image

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Related PRs

#6983

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Mar 26, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 26, 2022
@netlify
Copy link

netlify bot commented Mar 26, 2022

[V2]

Name Link
🔨 Latest commit 28761c4
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/623ecf6f5d0a160009fcd84c
😎 Deploy Preview https://deploy-preview-7015--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 45
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7015--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 806 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/css/styles.********.css 105 kB
website/build/assets/js/main.********.js 612 kB
website/build/index.html 38.4 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 3683f25 into main Mar 26, 2022
@Josh-Cena Josh-Cena deleted the jc/fix-sideba branch March 26, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants