Skip to content

refactor: console output improvements#7029

Merged
Josh-Cena merged 2 commits intomainfrom
lex111/minor-fixes
Mar 27, 2022
Merged

refactor: console output improvements#7029
Josh-Cena merged 2 commits intomainfrom
lex111/minor-fixes

Conversation

@lex111
Copy link
Contributor

@lex111 lex111 commented Mar 27, 2022

Motivation

Just small fixes and improvements.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

The changes are for CLI output, so nothing to test.

Related PRs

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Mar 27, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 27, 2022
typescript,
});
logger.success`
Created wrapper of name=${componentName} from name=${themeName} in path=${result.createdFiles}.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since it is a list (array), there is no need to place dot at the end.

@netlify
Copy link

netlify bot commented Mar 27, 2022

[V2]

Name Link
🔨 Latest commit 17cadcb
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/624035926015160009e9620c
😎 Deploy Preview https://deploy-preview-7029--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 62
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7029--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 806 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/css/styles.********.css 105 kB
website/build/assets/js/main.********.js 613 kB
website/build/index.html 38.4 kB

compressed-size-action

@Josh-Cena Josh-Cena changed the title refactor: minor code improvements refactor: console output improvements Mar 27, 2022
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants