Skip to content

Fix error in ts swizzle description#7100

Closed
Dr-Electron wants to merge 1 commit intofacebook:mainfrom
Dr-Electron:patch-1
Closed

Fix error in ts swizzle description#7100
Dr-Electron wants to merge 1 commit intofacebook:mainfrom
Dr-Electron:patch-1

Conversation

@Dr-Electron
Copy link
Contributor

Motivation

Current swizzle explanation isn't working

Have you read the Contributing Guidelines on pull requests?

yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 1, 2022
@netlify
Copy link

netlify bot commented Apr 1, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit b4f9e2c
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62477ab396d3c900082b8378
😎 Deploy Preview https://deploy-preview-7100--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 70
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7100--docusaurus-2.netlify.app/

@Josh-Cena
Copy link
Collaborator

Hi, npm requires -- to pass extra args to the script itself: https://docs.npmjs.com/cli/v8/commands/npm-run-script

Yarn doesn't, but this is a problem with our npm2yarn plugin in that it doesn't know to remove that --. See #6005

@Josh-Cena Josh-Cena closed this Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants