chore: replace concurrently with npm-run-all#7444
Merged
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 796 kB ℹ️ View Unchanged
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
concurrentlypulls in date-fns which is a lot of bloat. The entire dep tree ofconcurrentlyis 50MB, compared tonpm-run-all's 10MB.We'll also need to eventually get rid of
rxjsin our node_modules.wait-ondepends on it, but I believe it's unnecessary. We only have very lightweight usage ofwait-on.This is part of a bigger effort to migrate our building pipeline to something more light-weight while more robust. We'll use
run-pextensively for watch, so that CSS editing can be hot-reloaded.Test Plan
Tested locally by running
yarn watch. Hot reloading works.Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs