Skip to content

misc: make copyUntypedFiles work for watch mode#7445

Merged
Josh-Cena merged 1 commit intomainfrom
jc/fix-copyUntypedFiles
May 18, 2022
Merged

misc: make copyUntypedFiles work for watch mode#7445
Josh-Cena merged 1 commit intomainfrom
jc/fix-copyUntypedFiles

Conversation

@Josh-Cena
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

The last missing bit of DX. copyUntypedFiles.mjs now work for watch mode as well, with a simple chokidar watcher.

Test Plan

We can now hot-reload CSS as well! For example, here let's pretend we are editing Details/styles.module.css for theme-common (which used to not work):

Test

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: ignore This PR is not meaningful enough to appear in the changelog. label May 18, 2022
@Josh-Cena Josh-Cena requested review from lex111 and slorber as code owners May 18, 2022 11:05
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 18, 2022
@netlify
Copy link

netlify bot commented May 18, 2022

[V2]

Name Link
🔨 Latest commit 16d705d
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6284d304586b800009f3f096
😎 Deploy Preview https://deploy-preview-7445--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 89 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 82 🟢 99 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

Size Change: 0 B

Total Size: 796 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.3 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 599 kB
website/build/index.html 38.9 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 6b53d42 into main May 18, 2022
@Josh-Cena Josh-Cena deleted the jc/fix-copyUntypedFiles branch May 18, 2022 11:18
@slorber
Copy link
Collaborator

slorber commented May 25, 2022

great 👍 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: ignore This PR is not meaningful enough to appear in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants