Skip to content

fix(theme-classic): code block wrap mode should allow wrapping in the middle of a word#7551

Merged
slorber merged 1 commit intomainfrom
slorber/code-wrap-anywhere
Jun 2, 2022
Merged

fix(theme-classic): code block wrap mode should allow wrapping in the middle of a word#7551
slorber merged 1 commit intomainfrom
slorber/code-wrap-anywhere

Conversation

@slorber
Copy link
Collaborator

@slorber slorber commented Jun 2, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

When code block wrap mode is enabled, we should avoid displaying a vertical scrollbar at all cost and anways wrap (even if it's in a middle of a very long word that can't fit on the screen)

restore behavior from #7485 (comment)

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jun 2, 2022
@slorber slorber requested review from Josh-Cena and lex111 as code owners June 2, 2022 15:25
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 2, 2022
@netlify
Copy link

netlify bot commented Jun 2, 2022

[V2]

Name Link
🔨 Latest commit f49bcc1
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6298d66e36022a0009476ce6
😎 Deploy Preview https://deploy-preview-7551--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 86 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 85 🟢 99 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Size Change: 0 B

Total Size: 798 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.6 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 600 kB
website/build/index.html 38.9 kB

compressed-size-action

@slorber slorber merged commit 17fe43e into main Jun 2, 2022
@slorber slorber deleted the slorber/code-wrap-anywhere branch June 2, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants