Draft
Conversation
slorber
added
the
pr: ignore
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Size Change: 0 B Total Size: 802 kB ℹ️ View Unchanged
|
Josh-Cena
reviewed
Jul 1, 2022
| import {loadContext, type LoadContextOptions} from '../server'; | ||
| import {build} from './build'; | ||
|
|
||
| // Test temporary comment to trigger CI |
Collaborator
There was a problem hiding this comment.
Just add the workflow file to trigger conditions as well?
Collaborator
Author
|
Will have to figure out if we still have a deploy token set on this repo 😅 Not sure we could run this workflow on external PRs, as we'd need a user to push to the origin? 🤷♂️ |
This was referenced Jan 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
As mentioned in #7702, we don't have any automated way to ensure our deploy CLI keeps working over time, and any modification usually requires manual tests to ensure nothing gets broken.
These CLI scripts are not really easy to test as they usually run multiple complex Git commands.
I suggest we run as part of our CI tests to deploy a build dir to a real Git repo branch, ensuring at least the "happy path" of that script keeps working over time.
Test Plan
CI