chore: bump devcontainer to node 18#7726
chore: bump devcontainer to node 18#7726Josh-Cena merged 3 commits intofacebook:mainfrom jqshuv:main
Conversation
|
Hi @jqshuv! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
.devcontainer/devcontainer.json
Outdated
| "features": { | ||
| "node": { | ||
| "version": "14" | ||
| "version": "16" |
There was a problem hiding this comment.
Can we go directly to Node 18?
There was a problem hiding this comment.
I'll try it this evening but I think it should work if Docusaurus works on NodeJS 18.
There was a problem hiding this comment.
Yes, our docs recommend 18. I'm just not sure if devcontainer works with that...
Josh-Cena
left a comment
There was a problem hiding this comment.
Great, thanks!
I don't use devcontainers myself so it's always maintained by community contributors. Thanks for taking this up!
* fix: bump devcontainer to node 16 * fix: bump devcontainer directly to nodejs 18

Pre-flight checklist
Motivation
I decited to bump this version because I've tried to open this repo in a Remote-Container in vscode and got the error that you need at least NodeJS 16.
Test Plan
I've rebuilded the devcontainer and it worked without any errors.
Test links
Deploy preview: https://deploy-preview-7726--docusaurus-2.netlify.app/