Skip to content

Conversation

@slorber
Copy link
Collaborator

@slorber slorber commented Jul 25, 2022

Motivation

We are changing the way showcase sites are submitted: instead of users submitting a PR themselves, we just ask them to post a GitHub comment in #7826

This have several benefits:

  • it makes it easier for site owners to get their site added,
  • it does not require signing the Facebook CLA (which may sometimes be more complicated for companies)
  • it avoids the creation of too many PRs not directly related to Docusaurus changes
  • it saves a lot of time for the Docusaurus maintainers

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jul 25, 2022
@slorber slorber requested review from Josh-Cena and lex111 as code owners July 25, 2022 16:19
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 25, 2022
@netlify
Copy link

netlify bot commented Jul 25, 2022

[V2]

Name Link
🔨 Latest commit e5ecfba
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62dec2ab1ba3bc000735c0f7
😎 Deploy Preview https://deploy-preview-7828--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 82 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 74 🟢 100 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

Size Change: 0 B

Total Size: 805 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.8 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 608 kB
website/build/index.html 38.9 kB

compressed-size-action

@slorber slorber merged commit f21ee7c into main Jul 25, 2022
@slorber slorber deleted the slorber/change-showcase-process branch July 25, 2022 16:48
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants