Skip to content

Fix missing fblike button in blog #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yangshun merged 5 commits into from
Jul 1, 2018
Merged

Fix missing fblike button in blog #821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3311201
fix missing fblike in blog
endiliey Jul 1, 2018
1453ab6
add comment
endiliey Jul 1, 2018
b10a9cd
comment in js instead
endiliey Jul 1, 2018
56ca544
fb-comments too
endiliey Jul 1, 2018
68c0fa6
comment the right way
endiliey Jul 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/core/BlogPostLayout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ class BlogPostLayout extends React.Component {
const fbComment = this.props.config.facebookAppId &&
this.props.config.facebookComments && (
<div className="blogSocialSectionItem">
{/* Facebook SDK require 'fb-comments' class */}
<div
className="fb-comments"
data-href={
Expand All @@ -40,8 +41,9 @@ class BlogPostLayout extends React.Component {

const fbLike = this.props.config.facebookAppId && (
<div className="blogSocialSectionItem">
{/* Facebook SDK require 'fb-like' class */}
<div
className="fbLike"
className="fb-like"
data-href={
this.props.config.url +
this.props.config.baseUrl +
Expand Down
2 changes: 1 addition & 1 deletion lib/static/css/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2050,7 +2050,7 @@ input::placeholder {
padding-bottom: 5px;
}

.fbLike {
.fb-like {
Copy link
Contributor

@yangshun yangshun Jul 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment here that we shouldn't change this class because it's determined by FB SDK?

Copy link
Contributor Author

@endiliey endiliey Jul 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be in the js ? the css here just add extra style

Copy link
Contributor

@yangshun yangshun Jul 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but I renamed it thinking it was our own styling 😥

Copy link
Contributor

@yangshun yangshun Jul 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sure, let's write it in the JS then.

display: block;
margin-bottom: 20px;
width: 100%;
Expand Down