ESLintify Part 1#837
Conversation
|
Deploy preview for docusaurus-preview ready! Built with commit cae7d27 |
endiliey
left a comment
endiliey
left a comment
There was a problem hiding this comment.
Thanks for doing this. I had few comments though
| </a> | ||
| ); | ||
| }); | ||
| const showcase = siteConfig.users.filter(user => user.pinned).map(user => ( |
There was a problem hiding this comment.
Instead of filter and then map, I think using reduce can be a good idea
There was a problem hiding this comment.
I'd have to use an if inside reduce, which makes the code less declarative, so I don't think it's a good idea.
| const mkdirp = require('mkdirp'); | ||
| const glob = require('glob'); | ||
| const mkdirp = require('mkdirp'); | ||
| const nodePath = require('path'); |
There was a problem hiding this comment.
Is there a reason why we use nodePath instead of path ? I saw path being used in another file. Is there conflicting name here ?
lib/rename-version.js
Outdated
| let sidebarContent = fs.readFileSync(newSidebarFile, 'utf8'); | ||
| sidebarContent = sidebarContent.replace( | ||
| new RegExp(`version-${RegExp.escape(currentVersion)}-`, 'g'), | ||
| new RegExp(`version-${escapeRegexp(currentVersion)}-`, 'g'), |
There was a problem hiding this comment.
I think we can escape it using a library instead of our own escape function. Its alrd in our dependencies
There was a problem hiding this comment.
I'll look into using escape-string-regexp
lib/core/Head.js
Outdated
| let hasBlog = false; | ||
| links.map(link => { | ||
| if (link.blog) hasBlog = true; | ||
| links.forEach(link => { |
There was a problem hiding this comment.
const hasBlog = links.some(link => link.blog);
|
Hi 👋 I think there was a build failure from this. Syntax error? Maybe we need to upgrade our Circle build infra to support new constructs? Or there was a genuine error 😄 Sent with GitHawk |
|
Hmm odd. I'll look into it. |
5 participants
Motivation
Enable some ESLint rules by making the code ESLint-compliant.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Local + Netlify.
Related PRs
#836