fix: growth of content container to take all the available space#8442
Closed
dawei-wang wants to merge 2 commits intofacebook:mainfrom
Closed
fix: growth of content container to take all the available space#8442dawei-wang wants to merge 2 commits intofacebook:mainfrom
dawei-wang wants to merge 2 commits intofacebook:mainfrom
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Collaborator
|
@dawei-wang Normally I won't be reviewing CSS changes, but just want to drop by and say hi—nice seeing you here as well 😄 |
slorber
requested changes
Dec 15, 2022
Collaborator
There was a problem hiding this comment.
Unfortunately, we don't want to un-necessarily push the footer outside the full viewport height 😅
I want to see the full footer in the viewport here, and not having to scroll to see it.
https://deploy-preview-8442--docusaurus-2.netlify.app/tests/docs/doc-with-another-sidebar
Collaborator
|
Closing in favor of #8463 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #8369
Issue fix: To prevent content container growth, to take all the available space.
Pre-flight checklist
Motivation
Test Plan
Test links
https://deploy-preview-8442--docusaurus-2.netlify.app/
https://deploy-preview-8442--docusaurus-2.netlify.app/tests/docs/doc-with-another-sidebar
Related issues/PRs