Refactor + add more tests (Part 1)#847
Merged
yangshun merged 6 commits intofacebook:masterfrom Jul 13, 2018
Merged
Conversation
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit 3ad88a7 |
This was referenced Jul 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
server.jsandgenerate.jsChanges
Refactor duplicate
mdToHtmlfunction inserver.jsandgenerate.jshttps://github.com/facebook/Docusaurus/blob/a7a214fb3a36b3627e4346c2ddbcc4d01e3bf3a1/lib/server/generate.js#L108-L122
https://github.com/facebook/Docusaurus/blob/a7a214fb3a36b3627e4346c2ddbcc4d01e3bf3a1/lib/server/server.js#L198-L212
Move out
core/routing.jstoserver/routing.jsbecause it is more related to Express.js routingRefactor & Add tests for
getLanguageandgetSubDirinserver/utils.js😄Refactor duplicate
isSeparateCssfunction inserver.jsandgenerate.jshttps://github.com/facebook/Docusaurus/blob/a7a214fb3a36b3627e4346c2ddbcc4d01e3bf3a1/lib/server/server.js#L118-L128
https://github.com/facebook/Docusaurus/blob/a7a214fb3a36b3627e4346c2ddbcc4d01e3bf3a1/lib/server/generate.js#L74-L84
Refactor duplicate
insertTableOfContentsfunction inserver.jsandgenerate.jstocore/toc.js& add test for ithttps://github.com/facebook/Docusaurus/blob/a7a214fb3a36b3627e4346c2ddbcc4d01e3bf3a1/lib/server/generate.js#L60-L70
https://github.com/facebook/Docusaurus/blob/a7a214fb3a36b3627e4346c2ddbcc4d01e3bf3a1/lib/server/server.js#L106-L116
Moved
core/getTOC.jsfunction tocore/toc.jsso nowcore/toc.jshas two functions:Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
https://deploy-preview-847--docusaurus-preview.netlify.com/