fix(preset-classic): Pass Google Tag Manager configuration to correct plugin#8600
fix(preset-classic): Pass Google Tag Manager configuration to correct plugin#8600Addono wants to merge 1 commit intofacebook:mainfrom
Conversation
… plugin The current implementation of the plugin configuration builder of preset-classic incorrectly sets the configuration for the `googleTagManager`-tag. It tries to pass the Google Tag Manager configuration to the legacy GTag plugin, instead of the new Google Tag Manager plugin. This change routes the configuration to the correct plugin.
|
Hi @Addono! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Any instructions on how to test this change? It seems there's no test coverage for configuring the plugins through the classic-preset. At least, I cannot find a location in the tests where configuring the legacy GTag plugin is being set. And clearly the new plugin doesn't do this either. |
|
Duplicate of #8597 |
The current implementation of the plugin configuration builder of preset-classic incorrectly sets the configuration for the
googleTagManager-tag. It tries to pass the Google Tag Manager configuration to the legacy GTag plugin, instead of the new Google Tag Manager plugin.This change routes the configuration to the correct plugin.
Pre-flight checklist
Motivation
The newly added plugin for Google Tag Manager isn't properly integrated with the
classic-preset, as theclassic-preset tries to route the newly added config for the GTM plugin to the legacy GTag plugin.Therefore, preventing you from being able to confgure the GTM plugin from the
classic-preset.Test Plan
Test links
Deploy preview: https://deploy-preview-8600--docusaurus-2.netlify.app/
Related issues/PRs
#8470