fix(content-docs): sidebar generator should return customProps for doc items#9107
Merged
slorber merged 1 commit intofacebook:mainfrom Jun 29, 2023
TheCatLady:dh/sidebargenerator
Merged
fix(content-docs): sidebar generator should return customProps for doc items#9107slorber merged 1 commit intofacebook:mainfrom TheCatLady:dh/sidebargenerator
slorber merged 1 commit intofacebook:mainfrom
TheCatLady:dh/sidebargenerator
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
5 tasks
slorber
approved these changes
Jun 29, 2023
Collaborator
slorber
left a comment
slorber
left a comment
There was a problem hiding this comment.
Good catch, thanks for the fix 👍
Contributor
Author
|
@slorber I noticed that this PR didn't get labeled with Thanks for your prompt review of both PRs though! Really appreciate it 😺 |
slorber
added
pr: bug fix
Collaborator
|
Thanks, added the label :) |
slorber
pushed a commit
that referenced
this pull request
Sep 20, 2023
slorber
added a commit
that referenced
this pull request
Sep 20, 2023
…lease (#9324) Co-authored-by: Joshua Chen <sidachen2003@gmail.com> Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com> Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com> Co-authored-by: Ori Shalom <ori-shalom@users.noreply.github.com> Co-authored-by: Mikey O'Toole <mikey@homotechsual.dev> Co-authored-by: TheCatLady <52870424+TheCatLady@users.noreply.github.com> fix flaky screenshots, add html data-has-hydrated attribute (#9256) fix(theme-common): ThemedComponent should display something when JS is disabled (#9243) fix(theme): canonical url should be not change after hydration if url accessed with/without trailing slash (#9130) fix(theme): only set classname on ul elements if they have an existing class (#9099) fix(content-docs): sidebar generator should return customProps for doc items (#9107)
slorber
added
backported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
While customizing the sidebar generator behavior for a Docusaurus site I maintain, I discovered that
customPropswas missing on non-category sidebar items.Test Plan
Added a custom prop to an existing test and regenerated the snapshot.