Skip to content

Prettify all JavaScript files#964

Merged
yangshun merged 4 commits intomasterfrom
prettier
Sep 17, 2018
Merged

Prettify all JavaScript files#964
yangshun merged 4 commits intomasterfrom
prettier

Conversation

@yangshun
Copy link
Contributor

@yangshun yangshun commented Sep 17, 2018

Motivation

Enable Prettier for v2 files. I took the opportunity to clean up all the prettier commands into one since we don't run them separately anyway. Also, use a **/*.js pattern to just run on every file. We have no use case for not running Prettier on any directory for now.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

CI.

Related PRs

NA.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 17, 2018
@yangshun yangshun requested a review from endiliey September 17, 2018 07:17
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Sep 17, 2018 •
edited
Loading

Deploy preview for docusaurus-preview ready!

Built with commit ad840b9

https://deploy-preview-964--docusaurus-preview.netlify.com

endiliey
endiliey approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to delete local prettier related files in v2 folder. We have another .prettierrc and prettier command in v2 folder

@yangshun
Copy link
Contributor Author

yangshun commented Sep 17, 2018

@endiliey Thanks for the reminder. I also removed the .prettierignore file in v2 as I think it's safe to remove.

@yangshun yangshun merged commit 9d4a5d5 into master Sep 17, 2018
@yangshun yangshun deleted the prettier branch September 17, 2018 07:35
gustavohenke
gustavohenke reviewed Nov 5, 2018
View reviewed changes
.prettierrc
"proseWrap": "never",
"singleQuote": true,
"trailingComma": "es5"
"trailingComma": "all"
Copy link
Contributor

@gustavohenke gustavohenke Nov 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke Node 6 support (LTS until April 2019) 🙃

But I assume my CI file could be tweaked to not build docs on all supported versions...
https://github.com/express-validator/express-validator/blob/b4f0c256d281fb917b59221f4bfa93c2d81cd91a/.travis.yml

Copy link
Contributor Author

@yangshun yangshun Nov 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies. We did mention that Docusaurus requires Node 8 and above: https://docusaurus.io/docs/en/installation#installing-docusaurus

gustavohenke added a commit to express-validator/express-validator that referenced this pull request Nov 5, 2018
@gustavohenke
ci: don't build docs on Node.js v6
a955484 
facebook/docusaurus#964 (comment)
TigerStar429 pushed a commit to TigerStar429/expressjs-validator that referenced this pull request May 30, 2023
ci: don't build docs on Node.js v6
a611e66 
facebook/docusaurus#964 (comment)
@Qdigital Qdigital mentioned this pull request Jun 24, 2023
Open
@NikolayS NikolayS mentioned this pull request Jun 24, 2023
Open
@Qdigital Qdigital mentioned this pull request Jun 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@gustavohenke gustavohenke gustavohenke left review comments

@endiliey endiliey endiliey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yangshun @docusaurus-bot @gustavohenke @endiliey @facebook-github-bot