Conversation
endiliey
left a comment
There was a problem hiding this comment.
Few questions:
- The test fails on CI. Might need to fix it first.
- Why are we removing Open Collective ? That's the only reminder to user 😭
Kinda like the monorepo move, somewhat similar to jest monorepo
|
@endiliey I have fixed the tests. See if they're ok. I found the OC message spammy and I thought it was a bad idea to make users download an entire project just to show one message. I could add it back 🤣 The Netlify preview is failing because of the changed path, which I will fix after this PR gets merged. |
|
Haha, I think we can remove it since it downloads an entire package for that. Maybe we can be evil 😈 in the future and modify the Docusaurus CLI message such that it will show the Open Collective message and only stop if your email is registered as contributor. 🔥 🔥🔥🔥🔥🔥🔥🔥 |
|
Feel free to merge whenever you're ready |
|
Thanks, please help to test it if possible 😄 |
|
Upon investigation: We should not delete this, Then there is no |
|
My bad, the removal wasn't intentional. Will add it back. |
Motivation
Better separation of projects.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
yarn lintandyarn prettiercommands pass.Related PRs
NA
Next Steps