refactor(v2): use absolute path instead of alias for metadata source#967
Merged
endiliey merged 1 commit intofacebook:masterfrom Sep 18, 2018
Merged
refactor(v2): use absolute path instead of alias for metadata source#967endiliey merged 1 commit intofacebook:masterfrom
endiliey merged 1 commit intofacebook:masterfrom
Conversation
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit e99a634 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Current metadata for docs in v2 form is like below:
This is because I use @docs alias in webpack, but I guess this could be confusing and extra aliasing work. Let's just use absolute import so the generated sstructure is like below:
Extra: added stronger test for docs processing in v2
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
All the docs still working including relative linking