Conversation
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit b9159b4 |
Contributor
|
Edit: Didn't see the [WIP] Sorry ! |
Contributor
Author
|
@endiliey v1-tests are running now 😄 |
endiliey
reviewed
Sep 19, 2018
| - save-cache: *root-save-yarn-cache | ||
| - run: | ||
| name: Check Prettier & ESLint | ||
| command: cd v1 && yarn ci-check |
Contributor
There was a problem hiding this comment.
prettier is no longer being run. Is this intentional ?
Contributor
Author
|
Good catch @endiliey! I added a Prettier workflow which will run for both v1 and v2 code. |
Contributor
|
I think we should run v2-tests as well. WDYT ? If we want to be more efficient, then we can do some script to only run v1-test if v1 files is changed, and viceversa Edit: I mistakenly pressed wrong button & closed it :'( |
Contributor
Author
|
I'll add v2 tests in a follow up PR. This PR is already too big :)
Regards,
Yangshun
…On Wed, Sep 19, 2018 at 12:03 PM Endilie Yacop Sucipto < ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#968 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQRHV96OYDv-IJAzUddvyVidFDfY5e7ks5uccIogaJpZM4WtHJ2>
.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Per title.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
CI results.
Related PRs
NA.