Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
"url": "https://github.com/facebook/Docusaurus.git"
},
"scripts": {
"lint:v1": "cd v1 && yarn lint",
"lint:v2": "cd v2 && yarn lint",
"precommit": "lint-staged",
"prettier": "prettier --config .prettierrc --write \"**/*.js\"",
"prettier:diff": "prettier --config .prettierrc --list-different \"**/*.js\"",
Expand All @@ -17,7 +19,7 @@
},
"lint-staged": {
"linters": {
"{v1,v2}/**/*.js": ["yarn lint --fix", "yarn prettier", "git add"]
"{v1,v2}/**/*.js": ["yarn lint:v1 --fix", "yarn lint:v2 --fix", "yarn prettier", "git add"]
}
}
}
7 changes: 3 additions & 4 deletions v2/lib/core/clientEntry.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
import React from 'react';
import Loadable from 'react-loadable';
import {BrowserRouter} from 'react-router-dom';
import ReactDOM from 'react-dom';

import App from './App';
import prerender from './prerender';
import routes from '@generated/routes'; // eslint-disable-line

// Client side render (e.g: running in browser) to become single-page application (SPA)
if (typeof window !== 'undefined' && typeof document !== 'undefined') {
prerender(routes, window.location.pathname).then(() => {
if (typeof document !== 'undefined') {
Loadable.preloadReady().then(() => {
ReactDOM.render(
<BrowserRouter>
<App />
Expand Down
2 changes: 1 addition & 1 deletion v2/lib/core/prerender.js → v2/lib/core/preload.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {matchRoutes} from 'react-router-config';
* This helps us to make sure all the async component for that particular route
* is loaded before rendering. This is to avoid loading screens on first page load
*/
export default function prerender(routeConfig, providedLocation) {
export default function preload(routeConfig, providedLocation) {
const matches = matchRoutes(routeConfig, providedLocation);
return Promise.all(
matches.map(match => {
Expand Down
4 changes: 2 additions & 2 deletions v2/lib/core/serverEntry.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ import ReactDOMServer from 'react-dom/server';
import Helmet from 'react-helmet';

import App from './App';
import prerender from './prerender';
import preload from './preload';
import routes from '@generated/routes'; // eslint-disable-line
import webpackClientStats from '@build/client.stats.json'; //eslint-disable-line

// Renderer for static-site-generator-webpack-plugin (async rendering via promises)
export default function render(locals) {
return prerender(routes, locals.path).then(() => {
return preload(routes, locals.path).then(() => {
const context = {};
const appHtml = ReactDOMServer.renderToString(
<StaticRouter location={locals.path} context={context}>
Expand Down