Skip to content

Update docs-introduction.mdx#9810

Closed
opensourcejay wants to merge 1 commit intofacebook:mainfrom
opensourcejay:patch-1
Closed

Update docs-introduction.mdx#9810
opensourcejay wants to merge 1 commit intofacebook:mainfrom
opensourcejay:patch-1

Conversation

@opensourcejay
Copy link

@opensourcejay opensourcejay commented Jan 31, 2024

The current documentation says to add a routebasepath and set blog to false.

This ends up with an error when starting the application.

When removing the sidebar doc item it works as expected.

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

The current documentation says to add a routebasepath and set blog to false. 

This ends up with an error when starting the application. 

When removing the sidebar doc item it works as expected.
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 31, 2024
@netlify
Copy link

netlify bot commented Jan 31, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 2de2aea
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65ba04175abcec0008557aa7
😎 Deploy Preview https://deploy-preview-9810--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 56 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/installation 🟠 83 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog 🟠 67 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 64 🟢 97 🟢 100 🟢 100 🟠 89 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 80 🟠 89 Report
/blog/tags 🟠 76 🟢 100 🟢 100 🟢 90 🟠 89 Report

@slorber
Copy link
Collaborator

slorber commented Feb 1, 2024

I'm sorry but it's not clear to me why we would want to document that.

What error did you encounter? We don't even know? How removing these things does solve the error exactly?

I'm going to close until the problem is more clearly descrived in the first place, and will reopen eventually if you can convince me. In any case this PR can't be merged as is, because even I can't understand the why of these instructions.

@slorber slorber closed this Feb 1, 2024
@slorber slorber mentioned this pull request Feb 1, 2024
3 tasks
@opensourcejay opensourcejay deleted the patch-1 branch February 2, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants