fix(remark-npm2yarn): update npm-to-yarn from 2.0.0 to 2.2.1, fix pnpm extra args syntax#9861
Merged
fix(remark-npm2yarn): update npm-to-yarn from 2.0.0 to 2.2.1, fix pnpm extra args syntax#9861
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 992 kB ℹ️ View Unchanged
|
Josh-Cena
approved these changes
Feb 17, 2024
Collaborator
Contributor
Author
|
Yes same thing on my end but building locally does fix the issue weird... |
Collaborator
|
Could be because Netlify caches the dependencies. As long as the package actually delivers a fix, users will be able to update without us making any change, so we don't really have to worry about it. |
Collaborator
|
Yes maybe a cache issue 🤔 Issue fixed on prod website: Thanks 👍 going to consider it as a bugfix and backport in, just in case some users are affected by it |
This was referenced May 19, 2024
This was referenced May 22, 2024
This was referenced Aug 12, 2024
This was referenced Aug 15, 2024
This was referenced Aug 27, 2024
This was referenced Sep 4, 2024
This was referenced Sep 8, 2024
This was referenced Sep 11, 2024
This was referenced Sep 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pre-flight checklist
Motivation
As discussed in #9761 there is an error when converting npm commands with
--syntax to pnpm, pnpm doesn't support this syntaxUpdating to version 2.2.1 fixes this issue by removing
--in the converted commandTest Plan
Deploy preview
Test links
Deploy preview: https://deploy-preview-9861--docusaurus-2.netlify.app/docs/typescript-support#swizzling-typescript-theme-components
Related issues/PRs
#9761