Merged
Conversation
yangshun
suggested changes
Sep 29, 2018
Contributor
yangshun
left a comment
yangshun
left a comment
There was a problem hiding this comment.
The formatting and tests are failing, could you have a second look @fiennyangeln
Use custom transform for jest to handle docs test since there is path change in there
fiennyangeln
force-pushed
the
upgrade-babel-version
branch
from
166f22c to
676e0d6
Compare
Contributor
Author
|
@yangshun I just discover it happen because I had a build in the website directory previously.. Thats why the test seems fine it my computer. Will investigate tomorrow |
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit 978460f |
endiliey
approved these changes
Sep 30, 2018
Contributor
endiliey
left a comment
endiliey
left a comment
There was a problem hiding this comment.
Just slight nits. We might need to move v2 to Babel 7 as well. Wanna send a PR?
|
|
||
| function generateSite() { | ||
| shell.cd('website'); | ||
| shell.exec('yarn build', {silent: true}); |
fiennyangeln
force-pushed
the
upgrade-babel-version
branch
from
f47af8d to
5c94da5
Compare
- add babel/types to expose method used in translate-plugin
fiennyangeln
force-pushed
the
upgrade-babel-version
branch
from
5c94da5 to
978460f
Compare
Contributor
Author
|
@endiliey ok! let's do it in a different PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use custom transform for jest to handle docs test since there is
path change in there
Motivation
#984
(Write your motivation here.)
Have you read the Contributing Guidelines on pull requests?
Yes
(Write your answer here.)
Test Plan
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)