Skip to content

Drop dependency on deprecated gulp-util#279

Merged
zpao merged 1 commit intofacebook:masterfrom
TheDancingCode:issue-278
Jan 27, 2018
Merged

Drop dependency on deprecated gulp-util#279
zpao merged 1 commit intofacebook:masterfrom
TheDancingCode:issue-278

Conversation

@TheDancingCode
Copy link
Copy Markdown
Contributor

Closes #278

@facebook-github-bot
Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Copy Markdown

@demurgos demurgos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

Could we have this merged and published? The CI error is a timeout. It does not seem related to this change.

Copy link
Copy Markdown
Member

@zpao zpao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. Sorry for the long delay. It's not explicit in the linked issue in gulp-util but I assume this should be safe to ship in a patch release, right?

@zpao zpao merged commit cad6fd9 into facebook:master Jan 27, 2018
@demurgos
Copy link
Copy Markdown

Yes, this is a patch update from a semver point of view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants