Add missing iOS, tvOS & watchOS versions#656
Closed
vitalybu wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Vitaly Bukhovsky <vitalybu@gmail.com>
Contributor
Author
|
Also fixes #655 |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@c-ryan747 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@c-ryan747 merged this pull request in 11d452c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Display correct OS versions when listing simulators.
Test Plan
idb_companion --list 1now returns correctos_versionfor iOS 13.7 Simulators:{"model":"iPhone 11","os_version":"iOS 13.7","udid":"ECEE0585-05DB-4CD7-8F28-DD6D7CBD7174","architecture":"x86_64","type":"simulator","name":"iPhone 11","state":"Shutdown"} {"model":"iPhone 12 Pro Max","os_version":"iOS 14.4","udid":"24D12E6D-503C-4AB0-82F1-AFCB81182827","architecture":"x86_64","type":"simulator","name":"iPhone 12 Pro Max","state":"Shutdown"}Prior to this change, the default (latest == 14.4) version was returned.