Fix up compiler errors#889
Closed
dmaclach wants to merge 2 commits into
Closed
Conversation
amilich
added a commit
to amilich/idb
that referenced
this pull request
Dec 14, 2025
Two key fixes for idb_companion on macOS 12.1+: 1. FBSimulatorVideoStream.m: Don't require hardware-accelerated encoding for JPEG - The original code unconditionally required hardware acceleration on macOS 12.1+ - JPEG encoding may not have hardware encoder support on all systems - This caused VTCompressionSessionCreate to fail with -12902 (kVTParameterErr) - Now only H.264 requires hardware acceleration; JPEG prefers but doesn't require it 2. FBXcodeConfiguration.m: Fall back to xcode-select -p for developer directory - The symlink at /var/db/xcode_select_link no longer exists on modern macOS - Now tries the symlink first, then falls back to running xcode-select -p 3. FBSimulatorControl.xcodeproj: Mark required headers as Public - FBSimulatorApplicationCommands.h and FBSimulatorFileCommands.h need to be public - Required for idb_companion to build against the framework 4. Applied fixes from upstream PRs facebook#889 and facebook#895 for compilation issues These fixes enable MJPEG video streaming at ~30 FPS without requiring the simulator window to be visible on screen.
This was referenced Dec 14, 2025
Contributor
|
@xgerrit has imported this pull request. If you are a Meta employee, you can view this in D105367662. |
meta-codesync Bot
pushed a commit
that referenced
this pull request
May 15, 2026
Summary: ## Motivation Fix up some compilation problems building with Xcode 16.4 Pull Request resolved: #889 Reviewed By: bryanyantx Differential Revision: D105367662 Pulled By: xgerrit fbshipit-source-id: 376bf91d5c867188100a268ce7780f8e6d4c1ef9
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix up some compilation problems building with Xcode 16.4