Fix TypeGuard/TypeIs validation for functions without explicit return annotation #2017
+66
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Functions returning a TypeGuard/TypeIs value were incorrectly being validated as type guard functions even when they had no explicit return annotation.
For example:
has_int was being reported as an invalid TypeGuard function ("Type guard functions must accept at least one positional argument") because Pyrefly inferred its return type as TypeGuard[int] and then validated it as a type guard function.
The fix ensures TypeGuard/TypeIs validation only runs when the function has an explicit return annotation.
Fixes #1998
Test Plan