This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Fiber dev mode detection using a test function #709
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManasJayanth
force-pushed
the
fix-fiber-dev-mode-detection
branch
from
851be5f to
e84d66c
Compare
ManasJayanth
force-pushed
the
fix-fiber-dev-mode-detection
branch
from
e84d66c to
96ef966
Compare
ManasJayanth
commented
Jun 14, 2017
|
|
||
| // DEV mode check | ||
| if (testMinification() === 42) { | ||
| // __DEV__ block not removed. Do we warn in console? |
Contributor
Author
There was a problem hiding this comment.
@gaearon Need a little help here. If __DEV__ is not removed do we warn?
Contributor
Author
|
Failing flow check. Is it okay to change the type of |
Contributor
|
No, please add the new method to renderer definition in |
Contributor
Author
|
Not that it is necessary here, but what about |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting fix for #694. Yet to test creating bundle using patched react. Will post the results here.