Skip to content

Conversation

@huntie
Copy link
Member

@huntie huntie commented Mar 18, 2025

Summary

Follows #154.

Changing my mind: Let’s keep the current Network panel filter bar UI, which fits better with the reduced density of options under React Native. Whenever Chrome ships/abandons NETWORK_PANEL_FILTER_BAR_REDESIGN, we’ll follow. The extra forked code path shouldn’t matter massively — after this diff we support both.

Test plan

Screenshot 2025-03-18 at 12 45 44

✅ Legacy filter bar shown
✅ Intended filters are hidden

  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@huntie huntie merged commit 46feed4 into facebook:main Mar 18, 2025
1 of 2 checks passed
@huntie huntie deleted the network-ui-refinements branch March 18, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants