Update integration-with-existing-apps docs#2473
Open
friederbluemle wants to merge 1 commit intofacebook:mainfrom
Open
Update integration-with-existing-apps docs#2473friederbluemle wants to merge 1 commit intofacebook:mainfrom
friederbluemle wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Deploy preview for react-native ready! Built with commit 11fc50b |
friederbluemle
force-pushed
the
update-integ-guide
branch
from
e51e551 to
11fc50b
Compare
Collaborator
|
Hi @friederbluemle, thank you so much for working on this PR! 👍 I will try to test all your changes locally and provide the feedback this week. Refs #2118. |
Simek
reviewed
Feb 15, 2021
|
|
||
| ```shell | ||
| $ npx react-native bundle --platform android --dev false --entry-file index.js --bundle-output android/com/your-company-name/app-package-name/src/main/assets/index.android.bundle --assets-dest android/com/your-company-name/app-package-name/src/main/res/ | ||
| $ yarn react-native bundle --platform android --dev false --entry-file index.js --bundle-output android/app/src/main/assets/index.android.bundle --assets-dest android/app/src/main/res/ |
Collaborator
There was a problem hiding this comment.
Can you explain the reason for this change? Since CLI extraction from core, npx is a recommended way to call the RN scripts.
Also it would be nice if you can add the package manager Tabs (example: https://reactnative.dev/docs/next/typescript) to the code blocks which require calling yarn (or npm) directly.
Simek
added
the
Needs Author Feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several updates and clarifications in the "Integration with existing apps" guide for Android.
For example, the code was still mentioning the Android support libraries (replaced by
androidx.*). Also, there was a section about requesting the overlay permission (SYSTEM_ALERT_WINDOW) inonCreate(). This was fixed/improved in React Native 0.52+ and is no longer necessary (see facebook/react-native#16596). I rewrote and clarified the part about permissions and consolidated them into a section "Configuring AndroidManifest.xml".