-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Closed
Labels
Description
React Native version:
0.60.0
Steps To Reproduce
- Create new project
react-native init rn60stable && cd rn60stable - Run
npm run lint
Describe what you expected to happen:
- No errors
Snack, code example, or link to a repository:
- Output:
/Users/jonnyburger/rn60stable/App.js
9:16 error Replace `Fragment}·from·'react'` with `·Fragment·}·from·"react"` prettier/prettier
16:12 error Delete `,` prettier/prettier
17:8 error Replace `'react-native'` with `"react-native"` prettier/prettier
24:21 error Delete `,` prettier/prettier
25:8 error Replace `'react-native/Libraries/NewAppScreen'` with `"react-native/Libraries/NewAppScreen"` prettier/prettier
34:36 error Insert `⏎········` prettier/prettier
72:36 error Delete `,` prettier/prettier
75:34 error Delete `,` prettier/prettier
79:26 error Delete `,` prettier/prettier
83:17 error Replace `'600'` with `"600"` prettier/prettier
84:24 error Delete `,` prettier/prettier
89:17 error Replace `'400'` with `"400"` prettier/prettier
90:23 error Delete `,` prettier/prettier
93:17 error Replace `'700',` with `"700"` prettier/prettier
94:4 error Delete `,` prettier/prettier
/Users/jonnyburger/rn60stable/__tests__/App-test.js
5:8 error Replace `'react-native'` with `"react-native"` prettier/prettier
6:19 error Replace `'react'` with `"react"` prettier/prettier
7:17 error Replace `'../App'` with `"../App"` prettier/prettier
10:22 error Replace `'react-test-renderer'` with `"react-test-renderer"` prettier/prettier
12:4 error Replace `'renders·correctly'` with `"renders·correctly"` prettier/prettier
/Users/jonnyburger/rn60stable/babel.config.js
2:13 error Replace `'module:metro-react-native-babel-preset'],` with `"module:metro-react-native-babel-preset"]` prettier/prettier
/Users/jonnyburger/rn60stable/index.js
5:9 error Replace `AppRegistry}·from·'react-native'` with `·AppRegistry·}·from·"react-native"` prettier/prettier
6:17 error Replace `'./App'` with `"./App"` prettier/prettier
7:9 error Replace `name·as·appName}·from·'./app.json'` with `·name·as·appName·}·from·"./app.json"` prettier/prettier
/Users/jonnyburger/rn60stable/metro.config.js
13:30 error Delete `,` prettier/prettier
14:8 error Delete `,` prettier/prettier
15:7 error Delete `,` prettier/prettier
16:4 error Delete `,` prettier/prettier
Maybe there should be a prettier config? Or no prettier integration at all?
However, that there can be lint errors in a fresh projects does not seem right.
markkelsall, ecreeth, Gretchin, tsvetan-ganev, rszalski and 23 moreglaydsoncosta