RCTAppSetupPrepareApp breaks Flipper support on iOS

[oblador]

Description

In the latest RCs of RN 0.68.0 (tried 2 & 3) Flipper setup has moved into the RCTAppSetupPrepareApp helper. This effectively breaks integration as in this file FB_SONARKIT_ENABLED is not defined nor is the Flipper dependencies available as they are not listed in the React-Core podspec.

Copy-pasting the setup into the AppDelegate as it works in 0.67 and below restores the functionality.

Version

0.68.0-RC.3

Output of npx react-native info

System:
    OS: macOS 12.3
    CPU: (8) arm64 Apple M1
    Memory: 142.73 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.14.2 - ~/.volta/tools/image/node/16.14.2/bin/node
    Yarn: 1.22.17 - /opt/homebrew/bin/yarn
    npm: 8.5.0 - ~/.volta/tools/image/node/16.14.2/bin/npm
    Watchman: 2022.02.14.00 - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: 1.11.2 - /Users/joel.arvidsson/.asdf/shims/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 15.4, macOS 12.3, tvOS 15.4, watchOS 8.5
    Android SDK:
      API Levels: 30, 31, 32
      Build Tools: 30.0.2, 31.0.0, 32.0.0, 32.1.0
      System Images: android-30 | Google APIs ARM 64 v8a, android-32 | Google APIs ARM 64 v8a
      Android NDK: Not Found
  IDEs:
    Android Studio: 2021.1 AI-211.7628.21.2111.8193401
    Xcode: 13.3/13E113 - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.11 - /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.2 => 17.0.2 
    react-native: 0.68.0-rc.3 => 0.68.0-rc.3 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to reproduce

npx react-native init FlipperReproduction --version 0.68.0-rc.3
cd FlipperReproduction
yarn ios
open /Applications/Flipper.app # 0.140.0, but 0.125.0 is the same

Observe no application selectable:

Snack, code example, screenshot, or link to a repository

No response

[oblador]

Resolved in 0.68.0-rc.4 👍