Skip to content

Unbreak custom animated components #10827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oblador wants to merge 2 commits into from
Closed

Unbreak custom animated components #10827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
116f4eb
Move viewConfig check to setNativeProps
oblador Nov 9, 2016
ba3aff6
Use invariant instead of throwing an error
oblador Nov 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Libraries/Animated/src/AnimatedImplementation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1747,12 +1747,6 @@ function createAnimatedComponent(Component: any): any {
var callback = () => {
if (this._component.setNativeProps) {
if (!this._propsAnimated.__isNative) {
if (this._component.viewConfig == null) {
var ctor = this._component.constructor;
var componentName = ctor.displayName || ctor.name || '<Unknown Component>';
throw new Error(componentName + ' "viewConfig" is not defined.');
}

this._component.setNativeProps(
Copy link
Contributor

@leeight leeight Nov 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should ensure viewConfig exists before call setNativeProps

if (this._component.viewConfig != null) {
  this._component.setNativeProps(...);
}

See https://github.com/facebook/react-native/blob/master/Libraries/Renderer/src/renderers/native/NativeMethodsMixin.js#L141-L156

Copy link
Contributor

@leeight leeight Nov 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we can change throw new Erorr to console.warn??

Copy link
Contributor Author

@oblador oblador Nov 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leeight The problem is that custom components can proxy the setNativeProps call to the wrapped component which will throw/warn even though it's valid use. Isn't it better to do this check in the setNativeProps function instead?

Copy link
Contributor

@leeight leeight Nov 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oblador

Isn't it better to do this check in the setNativeProps function instead?

LGTM

this._propsAnimated.__getAnimatedValue()
);
Expand Down
6 changes: 6 additions & 0 deletions Libraries/Renderer/src/renderers/native/NativeMethodsMixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,12 @@ var NativeMethodsMixin = {
* Manipulation](docs/direct-manipulation.html)).
*/
setNativeProps: function(nativeProps: Object) {
if (!this.viewConfig) {
var ctor = this.constructor;
var componentName = ctor.displayName || ctor.name || '<Unknown Component>';
invariant(false, componentName + ' "viewConfig" is not defined.');
}

if (__DEV__) {
warnForStyleProps(nativeProps, this.viewConfig.validAttributes);
}
Expand Down