[website] Remove unused npm dependencies and add missing ones #14880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple of npm dependencies are unused (grepped for them or their variants since some are Babel presets/plugins) and there were also some missing that are listed in react-native's package.json but are directly required by the website. Test plan: follow the steps in the website README, open the website, browse a few different types of pages
facebook-github-bot
added
GH Review: review-needed
CLA Signed
Contributor
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
This requires manual import as we'll need to update the offline node modules cache in the internal repo. I've already made the necessary changes and am waiting for tests to run. Ping me if it's been a few days and I have not landed this. |
hramos
approved these changes
Jul 7, 2017
Contributor
|
Landing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of npm dependencies are unused (grepped for them or their variants since some are Babel presets/plugins) and there were also some missing that are listed in react-native's package.json but are directly required by the website.
Test plan: follow the steps in the website README, open the website, browse a few different types of pages