Remove onScrollAnimationEnd #15156
Closed
Remove onScrollAnimationEnd #15156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
shergin
suggested changes
Jul 23, 2017
Contributor
shergin
left a comment
shergin
left a comment
There was a problem hiding this comment.
And we also have to remove all mentions of it from ScrollView.js.
| .put(ScrollEventType.SCROLL.getJSEventName(), MapBuilder.of("registrationName", "onScroll")) | ||
| .put(ScrollEventType.BEGIN_DRAG.getJSEventName(), MapBuilder.of("registrationName", "onScrollBeginDrag")) | ||
| .put(ScrollEventType.END_DRAG.getJSEventName(), MapBuilder.of("registrationName", "onScrollEndDrag")) | ||
| .put(ScrollEventType.ANIMATION_END.getJSEventName(), MapBuilder.of("registrationName", "onScrollAnimationEnd")) |
Contributor
There was a problem hiding this comment.
We also have to remove ANIMATION_END from ScrollEventType.
Contributor
Author
|
Welp, that's why we have CR. Totally missed two. Fixed! |
Contributor
|
Great! I will land it tonight. |
facebook-github-bot
added
GH Review: accepted
Import Started
Contributor
|
@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.