Skip to content

Remove height styling when keyboard closed #16965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shauns wants to merge 2 commits into from
Closed

Remove height styling when keyboard closed #16965

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6a75bb
Remove height styling when keyboard closed
Nov 24, 2017
604ba01
Merge branch 'master' into patch-1
cpojer Jan 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Libraries/Components/Keyboard/KeyboardAvoidingView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ class KeyboardAvoidingView extends React.Component<Props, State> {
switch (behavior) {
case 'height':
let heightStyle;
if (this._frame != null) {
if (this._frame != null && this.state.bottom > 0) {
// Note that we only apply a height change when there is keyboard present,
// i.e. this.state.bottom is greater than 0. If we remove that condition,
// this.frame.height will never go back to its original value.
Expand Down