Add top offset for react loading view on Kitkat#17305
Closed
kmagiera wants to merge 1 commit intofacebook:masterfrom
Closed
Add top offset for react loading view on Kitkat#17305kmagiera wants to merge 1 commit intofacebook:masterfrom
kmagiera wants to merge 1 commit intofacebook:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
|
@facebook-github-bot label Core Team Generated by 🚫 dangerJS |
kmagiera
force-pushed
the
fixLoadingViewOffsetOnKitkat
branch
from
25afd74 to
e56a401
Compare
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@achen1 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
nice. thanks for the quick fix! |
ide
pushed a commit
to expo/react-native
that referenced
this pull request
Jan 9, 2018
Summary: This PR fixes the problem with dev loading view on KitKat and older Android devices after facebook#16596 Install RNTester app on Android API 19 or lower device. See green loading view show up under status bar. Do the same with full screen theme set and see it show up correctly at the top of the screen. Verify the green loading bar displays correctly on devices with API > 19 too. This fixes an issue introduced in facebook#16596 [ANDROID][MINOR][DevSupport] - Fix green dev loading bar on Android Kitkat and below Closes facebook#17305 Differential Revision: D6621077 Pulled By: achen1 fbshipit-source-id: 3b4216af535d7db5c96d137f20004fe2651b1dc9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes the problem with dev loading view on KitKat and older Android devices after #16596
Test Plan
Install RNTester app on Android API 19 or lower device. See green loading view show up under status bar. Do the same with full screen theme set and see it show up correctly at the top of the screen.
Verify the green loading bar displays correctly on devices with API > 19 too.
Related PRs
This fixes an issue introduced in #16596
Release Notes
[ANDROID][MINOR][DevSupport] - Fix green dev loading bar on Android Kitkat and below