Skip to content

Bump Android Support Library to 27.1.1 #20586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dulmandakh wants to merge 6 commits into from
Closed

Bump Android Support Library to 27.1.1 #20586

dulmandakh wants to merge 6 commits into from
+39 −27

Conversation

@dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Aug 9, 2018

This PR bumps Android Support Library version to 27.1.1.

FYI, originally was a part of #20026.

Test Plan:

Everything builds and runs as normal.

Release Notes:

[ANDROID] [ENHANCEMENT] [Android Support Library] - Bump to version 27.1.1

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 9, 2018
@dulmandakh dulmandakh requested review from gengjiawen and hramos August 9, 2018 00:40
gengjiawen
gengjiawen suggested changes Aug 9, 2018
View reviewed changes
local-cli/templates/HelloWorld/android/build.gradle Outdated

task wrapper(type: Wrapper) {
gradleVersion = '4.4'
gradleVersion = '4.8'
Copy link
Contributor

@gengjiawen gengjiawen Aug 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 4.8 here ?

Copy link
Contributor

@gengjiawen gengjiawen Aug 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also use wrapper task to update, don't change gradle-wrapper.properties directly.

@dulmandakh
Copy link
Contributor Author

dulmandakh commented Aug 9, 2018

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 9, 2018

I will not rubber stamp and land your change for you @dulmandakh! I can import it for you and you can get your change reviewed by someone though :)

@gengjiawen
Copy link
Contributor

gengjiawen commented Aug 9, 2018

maybe wait for 28 stable release.

@dulmandakh
Copy link
Contributor Author

dulmandakh commented Aug 9, 2018

@gengjiawen maybe, but it might be better to migrate to AndroidX once it becomes stable.

@dulmandakh
Copy link
Contributor Author

dulmandakh commented Aug 13, 2018

@hramos please review and merge. I found that some apps and libraries from Android use support library 27.x version.

@dulmandakh dulmandakh mentioned this pull request Aug 14, 2018
Closed
13 tasks
@gengjiawen
Copy link
Contributor

gengjiawen commented Aug 17, 2018

I think the most import thing is android gradle plugin compatible to 3.x, can we put that first ? @dulmandakh .

@hramos
Copy link
Contributor

hramos commented Aug 17, 2018

@gengjiawen are you asking for changes, or is this PR good to go?

@gengjiawen
Copy link
Contributor

gengjiawen commented Aug 17, 2018

this pr is good to go. This pr is split from a big pr, I want android gradle plugin compatible to 3.x comes first since it's more important. Bump to 28 can wait since it comes out recently.

@dulmandakh
Copy link
Contributor Author

dulmandakh commented Aug 19, 2018

rebased to master, and it works. please merge 👍

@dulmandakh
Copy link
Contributor Author

dulmandakh commented Aug 20, 2018

@gengjiawen we shouldn't be blocking unrelated PRs because of gradle plugin 3.x. Or we should be working to improve RN tooling where possible.

Yes, I agree that gradle plugin 3.x support is very important, so I took https://gradle.org/training/intro-to-gradle/ training and learnt some basics about gradle. Also I'm planning to create small PRs to cleanup and refactor gradle scripts, then make it compatible with gradle plugin 3.x.

@gengjiawen
Copy link
Contributor

gengjiawen commented Aug 20, 2018

For now, the script is compatible with gradle 3.x, I think we should do it now.

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Aug 20, 2018
facebook-github-bot
facebook-github-bot approved these changes Aug 20, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

react-native-bot commented Aug 21, 2018

This pull request was closed by @dulmandakh in 874cca1.

Once this commit is added to a release, you will see the corresponding version tag below the description at 874cca1. If the commit has a single master tag, it is not yet part of a release.

@facebook facebook locked as resolved and limited conversation to collaborators Aug 21, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Aug 21, 2018
@dulmandakh dulmandakh deleted the bump-support-library-27 branch August 22, 2018 03:15
kelset pushed a commit that referenced this pull request Aug 23, 2018
@dulmandakh @kelset
Bump Android Support Library to 27.1.1 (#20586)
d9868f7 
Summary:
This PR bumps Android Support Library version to 27.1.1.

FYI, originally was a part of #20026.
Pull Request resolved: #20586

Differential Revision: D9414901

Pulled By: hramos

fbshipit-source-id: 580338e62a924c214accc5d944f17c81ad9e3f9f
aleclarson pushed a commit to aleclarson/react-native that referenced this pull request Sep 16, 2018
@dulmandakh @aleclarson
Bump Android Support Library to 27.1.1 (facebook#20586)
a133912 
Summary:
This PR bumps Android Support Library version to 27.1.1.

FYI, originally was a part of facebook#20026.
Pull Request resolved: facebook#20586

Differential Revision: D9414901

Pulled By: hramos

fbshipit-source-id: 580338e62a924c214accc5d944f17c81ad9e3f9f
grabbou pushed a commit to react-native-community/cli that referenced this pull request Sep 26, 2018
@dulmandakh @facebook-github-bot
Bump Android Support Library to 27.1.1 (#20586)
806a938 
Summary:
This PR bumps Android Support Library version to 27.1.1.

FYI, originally was a part of facebook/react-native#20026.
Pull Request resolved: facebook/react-native#20586

Differential Revision: D9414901

Pulled By: hramos

fbshipit-source-id: 580338e62a924c214accc5d944f17c81ad9e3f9f
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
rozele pushed a commit to microsoft/react-native-windows that referenced this pull request Apr 14, 2019
@dulmandakh @facebook-github-bot
Bump Android Support Library to 27.1.1 (#20586)
4792bbc 
Summary:
This PR bumps Android Support Library version to 27.1.1.

FYI, originally was a part of facebook/react-native#20026.
Pull Request resolved: facebook/react-native#20586

Differential Revision: D9414901

Pulled By: hramos

fbshipit-source-id: 580338e62a924c214accc5d944f17c81ad9e3f9f
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
@dulmandakh @facebook-github-bot
Bump Android Support Library to 27.1.1 (facebook#20586)
c1b1013 
Summary:
This PR bumps Android Support Library version to 27.1.1.

FYI, originally was a part of facebook#20026.
Pull Request resolved: facebook#20586

Differential Revision: D9414901

Pulled By: hramos

fbshipit-source-id: 580338e62a924c214accc5d944f17c81ad9e3f9f
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
@dulmandakh @kelset
Bump Android Support Library to 27.1.1 (facebook#20586)
ee55000 
Summary:
This PR bumps Android Support Library version to 27.1.1.

FYI, originally was a part of facebook#20026.
Pull Request resolved: facebook#20586

Differential Revision: D9414901

Pulled By: hramos

fbshipit-source-id: 580338e62a924c214accc5d944f17c81ad9e3f9f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

@hramos hramos Awaiting requested review from hramos

+1 more reviewer

@gengjiawen gengjiawen gengjiawen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dulmandakh @facebook-github-bot @gengjiawen @hramos @react-native-bot