Fix regression in Android unlink command #21043
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 4dfdec9 introduced a regression in the `unlink` command for Android projects: native modules previously linked with the now-deprecated `compile` configuration will not be detected anymore and by extension will not be unlinked. `unlink` should be aware of both new and deprecated options to ensure functionality also in existing projects that previously linked modules with the old convention. This commit fixes the regression by: - first, `makeDeprecatedNativeModule` is added so to have the deprecated patch line that could be present in the Gradle build file. - updating the Android `isInstalled` to check, for a given package name, for both `compile` and `implementation` dependencies records in `build.gradle`. - Android `unregisterNativeModule` will proceed to revoke both possible patch lines from `build.gradle`.
facebook-github-bot
added
the
CLA Signed
Contributor
Author
react-native-bot
added
Platform: Android
matei-radu
referenced
this pull request
Sep 11, 2018
Summary: Motivation: -------------- PR #20767 bumped the version of the Android Gradle Plugin to v3 which uses the newer Gradle dependency configurations `implementation` and `api` which make `compile` obsolete. While the PR updated the template Gradle configuration, it did not cover the `link` command which will still link native modules using `compile` resulting in a warning message beeing displayed during an app build. Since `compile` will be eventually removed by Gradle, this commit updates the `link` command to attach native modules using `implementation`. Pull Request resolved: #20853 Differential Revision: D9733888 Pulled By: hramos fbshipit-source-id: 22853480d7ba7be65e3387effda2fd6c72b6906a
Contributor
Author
|
@grabbou since your proposal passed (congrats 🎉), shall we postpone this until we separate the CLI or proceed as always? |
Contributor
|
Thank you for your PR. We just moved this code to https://github.com/react-native-community/react-native-cli so please submit your PR there. |
Contributor
|
Hey @matt-block! Thanks for submitting this PR! Apologies for not getting back, but the whole CLI extraction process got me super busy with other notifications. We ended up fixing this bug in the CLI with this PR: react-native-community/cli#81 which takes a slightly different approach compared to your take. Would love to hear your opinion about that take - please feel free to comment on the PR or message me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Commit 4dfdec9 introduced a regression in the
unlinkcommand for Android projects: native modules previously linked with the now-deprecatedcompileconfiguration will not be detected anymore and by extension will not be unlinked.unlinkshould be aware of both new and deprecated options to ensure functionality also in existing projects that previously linked modules with the old convention.This PR fixes the regression by:
makeDeprecatedNativeModuleis added so to have the deprecated patch line that could be present in the Gradle build file.isInstalledto check, for a given package name, for bothcompile(using the function introduced in step 1) andimplementationdependency records inbuild.gradle.unregisterNativeModulewill proceed to revoke both possible patch lines frombuild.gradle.This PR together with commit 4dfdec9 provide the following behaviour:
linkwill continue to work as intended usingimplementation. This works without issues even with older packages that still usecompileinternally for their own dependencies.linkwill detect previously linked packages withcompileand will not proceed with a new linkage. Instead, it will log thatPlatform 'android' module X is already linked.unlinkwill detect dependencies with bothcompileandimplementationand proceed to unlink as expected.Test Plan:
compileand the described behaviour listed above was matched.Related PRs:
Release Notes:
[CLI] [BUGFIX] [local-cli/link] - Fixed regression in Android
unlink.