Use relative path for SCRIPTDIR #22598
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Generated by 🚫 dangerJS |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Dec 11, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
kelset
pushed a commit
that referenced
this pull request
Dec 12, 2018
Summary: Fixes #22521 The current approach has an issue with white spaces when compiling in Xcode 10.1  Change back to relative path fixes this issue Pull Request resolved: #22598 Differential Revision: D13421446 Pulled By: hramos fbshipit-source-id: 688157b2e951399059cb6c95e2a6ce8d176e9b9c
grabbou
pushed a commit
that referenced
this pull request
Dec 17, 2018
Summary: Fixes #22521 The current approach has an issue with white spaces when compiling in Xcode 10.1  Change back to relative path fixes this issue Pull Request resolved: #22598 Differential Revision: D13421446 Pulled By: hramos fbshipit-source-id: 688157b2e951399059cb6c95e2a6ce8d176e9b9c
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Fixes facebook#22521 The current approach has an issue with white spaces when compiling in Xcode 10.1  Change back to relative path fixes this issue Pull Request resolved: facebook#22598 Differential Revision: D13421446 Pulled By: hramos fbshipit-source-id: 688157b2e951399059cb6c95e2a6ce8d176e9b9c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22521
The current approach has an issue with white spaces when compiling in Xcode 10.1
Change back to relative path fixes this issue
Test Plan:
Init a new project with white space in the name and compile it in Xcode. It should pass with this pr.
Changelog:
None