Update Gradle wrapper to 4.10.3 #23341
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
friederbluemle
force-pushed
the
update-gradle-wrapper
branch
2 times, most recently
from
1b6a901 to
52814ed
Compare
Contributor
Author
|
Rebased onto latest |
friederbluemle
force-pushed
the
update-gradle-wrapper
branch
2 times, most recently
from
48a4b98 to
313548e
Compare
Contributor
|
We're updating to Gradle 5.0 in #23324. |
friederbluemle
force-pushed
the
update-gradle-wrapper
branch
from
313548e to
a7ae0b2
Compare
Contributor
Author
|
@hramos - Thanks for your comment. Yes, I know - That's why I linked the PR in the description :) As much as I applaud the usage of newer versions, don't you think it would be advisable to keep the Gradle wrapper version in sync with whatever the currently used Android Gradle plugin officially supports? For Android Gradle plugin |
Contributor
|
I'll let you and @dulmandakh sort this out. |
Contributor
|
I'm going to close this, as #23324 is landing. Happy to hear any arguments in favor of downgrading to 4.10.3 from 5.0. I'm following @dulmandakh advice given he has been actively sending PRs to upgrade our Gradle config over the past year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Projects generated with the latest stable version of Android Studio come with Gradle wrapper
4.10.1. The Gradle documentation states:Currently,
react-nativeis using4.10.2. This PR brings Gradle wrapper from4.10.2to4.10.3. Updates were automatically performed using thegradle wrappertask.Related: #23324
Changelog
[Android] [Added] - Update Gradle wrapper to 4.10.3
Test Plan
Regular testing. No changes.