Fix prop overrides of TouchableWithoutFeedback #23966
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Child props were being overridden by <Touchable> props even when the <Touchable> props were undefined.
facebook-github-bot
added
the
CLA Signed
analysis-bot
suggested changes
Mar 15, 2019
analysis-bot
left a comment
analysis-bot
left a comment
There was a problem hiding this comment.
Code analysis results:
flowfound some issues.
| } | ||
|
|
||
| const overrides = {}; | ||
| for (const prop of OVERRIDE_PROPS) { |
There was a problem hiding this comment.
Cannot get this.props[prop] because property accessibilityIgnoresInvertColors is missing in propTypes of React component [1].
facebook-github-bot
approved these changes
Mar 18, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
Ah, thanks for the patch. I was just about to get back to you about that :D |
facebook-github-bot
approved these changes
Mar 18, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @aleclarson in 68825f9. When will my fix make it into a release? | Upcoming Releases |
grabbou
pushed a commit
that referenced
this pull request
May 6, 2019
Summary: Child props were being overridden by `<Touchable>` props even when the `<Touchable>` props were undefined. [General] [Fixed] - Prevent prop override by TouchableWithoutFeedback when undefined Pull Request resolved: #23966 Differential Revision: D14502918 Pulled By: cpojer fbshipit-source-id: 614ee43bbb6f062a98bd9318693807320979a016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Child props were being overridden by
<Touchable>props even when the<Touchable>props were undefined.Changelog
[General] [Fixed] - Prevent prop override by TouchableWithoutFeedback when undefined
Test Plan
None yet