Skip to content

Adds Logic To Catch MissingWebViewPackageException #24533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thorbenprimke wants to merge 2 commits into from
Closed

Adds Logic To Catch MissingWebViewPackageException #24533

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c751c5
[ForwardingCookieHandler] Adds Logic To Catch MissingWebViewPackageEx…
Apr 19, 2019
d2e150b
Update ForwardingCookieHandler.java
cpojer Apr 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ReactAndroid/src/main/java/com/facebook/react/modules/network/ForwardingCookieHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,17 @@ protected void doInBackgroundGuarded(Void... params) {
} catch (IllegalArgumentException ex) {
// https://bugs.chromium.org/p/chromium/issues/detail?id=559720
return null;
} catch (Exception exception) {
String message = exception.getMessage();
// We cannot catch MissingWebViewPackageException as it is in a private / system API
// class. This validates the exception's message to ensure we are only handling this
// specific exception.
// https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/webkit/WebViewFactory.java#98
if (message != null && message.contains("No WebView installed")) {
return null;
} else {
throw exception;
}
}

if (USES_LEGACY_STORE) {
Expand Down