Skip to content

Conversation

@thecodrr
Copy link
Contributor

@thecodrr thecodrr commented Aug 1, 2019

Summary

This adds the @DoNotStrip annotation to disallow Proguard/R8 from stripping the AndroidUnicodeUtils class during release build and causing a ClassNotFound crash.

Changelog

[Internal] [Fixed] - Fixed ClassNotFound exception in Android during Release builds

Test Plan

This adds the @DoNotStrip annotation to disallow Proguard/R8 from stripping the AndroidUnicodeUtils class during release build and causing a `ClassNotFound` crash.
@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Aug 1, 2019
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 1, 2019
@pull-bot
Copy link

pull-bot commented Aug 1, 2019

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Generated by 🚫 dangerJS against 39ffc20

@thecodrr thecodrr changed the title Add DoNotStrip annotation for Hermes Fix ClassNotFound exception in Android during Release builds Aug 1, 2019
@react-native-bot react-native-bot added Platform: Android Android applications. Bug labels Aug 1, 2019
Copy link
Contributor

@janicduplessis janicduplessis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also add @DoNotStrip on all the methods, I still had a crash before doing so when testing in my app.

@thecodrr
Copy link
Contributor Author

thecodrr commented Aug 2, 2019

@janicduplessis done

@thymikee thymikee requested a review from janicduplessis August 2, 2019 12:58
Copy link
Contributor

@mdvacca mdvacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, I'm importing it!
Thanks for working on this.

@janicduplessis
Copy link
Contributor

@mdvacca This actually needs to go in the 0.60 branch, I think we can just merge it directly on github. This is because we landed 2 different versions of the hermes commit in 0.60 and master.

@janicduplessis janicduplessis merged commit ffdf3f2 into facebook:0.60-stable Aug 2, 2019
@mdvacca
Copy link
Contributor

mdvacca commented Aug 2, 2019

Thanks @janicduplessis, that's why I was having problems in the import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Platform: Android Android applications. Type: Enhancement A new feature or enhancement of an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants