-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Fix ClassNotFound exception in Android during Release builds
#25912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds the @DoNotStrip annotation to disallow Proguard/R8 from stripping the AndroidUnicodeUtils class during release build and causing a `ClassNotFound` crash.
|
ClassNotFound exception in Android during Release builds
janicduplessis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should also add @DoNotStrip on all the methods, I still had a crash before doing so when testing in my app.
|
@janicduplessis done |
mdvacca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, I'm importing it!
Thanks for working on this.
|
@mdvacca This actually needs to go in the 0.60 branch, I think we can just merge it directly on github. This is because we landed 2 different versions of the hermes commit in 0.60 and master. |
|
Thanks @janicduplessis, that's why I was having problems in the import. |
Summary
This adds the
@DoNotStripannotation to disallow Proguard/R8 from stripping theAndroidUnicodeUtilsclass during release build and causing aClassNotFoundcrash.Changelog
[Internal] [Fixed] - Fixed
ClassNotFoundexception in Android during Release buildsTest Plan