Add bundleId parameter (follow-up to #27844 and #27855) #27875
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
simka
changed the title
simka
force-pushed
the
feat/bundle-id-for-multibundle
branch
from
b7d33b9 to
0f553ed
Compare
simka
force-pushed
the
feat/bundle-id-for-multibundle
branch
2 times, most recently
from
ead90f7 to
918c46b
Compare
simka
force-pushed
the
feat/bundle-id-for-multibundle
branch
from
918c46b to
be5f557
Compare
zamotany
force-pushed
the
feat/bundle-id-for-multibundle
branch
from
be5f557 to
d111397
Compare
zamotany
force-pushed
the
feat/bundle-id-for-multibundle
branch
from
d111397 to
afb66bf
Compare
|
any updates ? |
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
Stale
|
This PR was closed because it has been stalled for 7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the third (and last) of three PRs related to enabling multi-bundle support in React Native. First one can be found here and the second one here. More details, motivation and reasoning behind multi-bundle support can be found in RFC here.
As the first and second one, it's based on @dratwas work from here, but applied to current
masterto avoid rebasing 3-months old branch and issues that come with that.Changelog
[Internal] [Changed] - Added
bundleIdparam to enable multi-bundle support in the futureTest Plan
Initialized new RN app with CLI, set RN to build from source and verified the still app builds and runs OK using code from this branch.